Re: [libvirt-glib PATCHv2 4/5] gobject: Add wrapper for virNetworkDHCPLease

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

Looks good to me, I'd name the type GVirNetworkDhcpLease rather than
GVirNetworkDHCPLease, this is consistent with
GVirConfigCapabilitiesCpuModel (and not CPUModel).

Maybe more descriptive doc for some of the fields (client id, iaid, ...)
could be useful? Or are they just obvious for someone familiar with
dhcp?


On Mon, Jun 29, 2015 at 03:08:54PM +0100, Zeeshan Ali (Khattak) wrote:
> diff --git a/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c
> new file mode 100644
> index 0000000..57ccf0d
> --- /dev/null
> +++ b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c
> @@ -0,0 +1,252 @@
> +/*
> + * libvirt-gobject-network-dhcp-lease.h: libvirt glib integration

This is the .c file, not the .h file.


Christophe

Attachment: pgplrg8SyBbcs.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]