On 01.06.2015 20:40, Lubomir Rintel wrote: > There was a couple of problems with the style fixes applied to the original > patch: > > 1.) virFileReadAllQuiet comparison was incorrectly parenthesized when moved > into a condition, causing the len to be set to the result of comparison. This, > together with the removed underflow check would underflow the phy buffer. > > 2.) The logic was broken. Failure to call "ip" would abort the function, thus > the "iw" branch would never be reached. > > This aims to fix the issues and work around possible style complains :) > > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx> > --- > src/util/virnetdev.c | 46 +++++++++++++++++++++------------------------- > 1 file changed, 21 insertions(+), 25 deletions(-) ACked and pushed. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list