Re: [PATCH] storage: tweak condition to properly test lseek

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 03, 2015 at 12:10:46 -0700, Eric Blake wrote:
> On 03/03/2015 08:57 AM, Erik Skultety wrote:
> > According to the POSIX standard, off_t (returned by lseek) is defined as
> > signed integral type no shorter than int. Because our offset variable is defined
> > as unsigned long long, the original check was passed successfully if UINT64_MAX had
> > been used as offset value, due to implicit conversion.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177219
> > ---
> >  src/fdstream.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ACK.

Pushed; Erik still doesn't have commit access.

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]