On Wed, Feb 25, 2015 at 09:01:49 +0100, Peter Krempa wrote: > On Tue, Feb 24, 2015 at 17:25:55 +0100, Erik Skultety wrote: > > According to docs, we only support 2 link states for an interface > > up/down, 'up' being the default state if link state is unspecified in > > domain's XML, so the message when no link state is provided should be > > changed a little. > > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1141119 > > Hmm, yeah, having the default state to be anything else than up doesn't > make much sense. I chose it originally to denote that the link state was > not configured explicitly. > > > > --- > > tools/virsh-domain-monitor.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c > > index 925eb1b..18ce9ae 100644 > > --- a/tools/virsh-domain-monitor.c > > +++ b/tools/virsh-domain-monitor.c > > @@ -756,7 +756,7 @@ cmdDomIfGetLink(vshControl *ctl, const vshCmd *cmd) > > if ((state = virXPathString("string(./link/@state)", ctxt))) > > vshPrint(ctl, "%s %s", iface, state); > > else > > - vshPrint(ctl, "%s default", iface); > > + vshPrint(ctl, "%s up", iface); > > > > ret = true; > > ACK, after release of 1.2.13. Pushed now;
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list