Re: [PATCH 06/24] conf: numa: Rename virDomainNumatune to virDomainNuma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/16/2015 01:51 PM, Peter Krempa wrote:
> The structure will gradually become the only place for NUMA related
> config, thus rename it appropriately.
> ---
>  src/conf/domain_conf.c        | 10 +++---
>  src/conf/domain_conf.h        |  2 +-
>  src/conf/numa_conf.c          | 78 +++++++++++++++++++++----------------------
>  src/conf/numa_conf.h          | 34 +++++++++----------
>  src/libvirt_private.syms      |  4 +--
>  src/lxc/lxc_cgroup.c          |  4 +--
>  src/lxc/lxc_controller.c      |  6 ++--
>  src/lxc/lxc_native.c          |  2 +-
>  src/parallels/parallels_sdk.c |  2 +-
>  src/qemu/qemu_cgroup.c        | 12 +++----
>  src/qemu/qemu_command.c       |  8 ++---
>  src/qemu/qemu_driver.c        | 20 +++++------
>  src/qemu/qemu_process.c       |  4 +--
>  13 files changed, 93 insertions(+), 93 deletions(-)
> 

Interesting that only virDomainNumatuneFree and virDomainNumatuneEquals
changes names, um err...  I guess I should say my eyes thank you for not
changing every function name too ;-)

<...snip...>

> 
> diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
> index d8f1739..bcb8023 100644
> --- a/src/conf/numa_conf.c
> +++ b/src/conf/numa_conf.c

<...snip...>

> @@ -572,8 +572,8 @@ virDomainNumatuneNodesEqual(virDomainNumatunePtr n1,
>  }
> 
>  bool
> -virDomainNumatuneEquals(virDomainNumatunePtr n1,
> -                        virDomainNumatunePtr n2)
> +virDomainNumaEquals(virDomainNumaPtr n1,
> +                        virDomainNumaPtr n2)

                       ^^^^
Extraneous spacing

>  {
>      if (!n1 && !n2)
>          return true;



ACK -

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]