Re: [PATCH 04/24] conf: numa: Don't duplicate NUMA cell cpumask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/16/2015 01:51 PM, Peter Krempa wrote:
> The mask was stored both as a bitmap and as a string. The string is used
> for XML output only. Remove the string, as it can be reconstructed from
> the bitmap.
> 
> The test change is necessary as the bitmap formatter doesn't "optimize"
> using the '^' operator.
> ---
>  src/conf/cpu_conf.c                                        | 14 +++++++-------
>  src/conf/cpu_conf.h                                        |  1 -
>  src/conf/numa_conf.c                                       |  3 +--
>  tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.xml   |  2 +-
>  .../qemuxml2xmloutdata/qemuxml2xmlout-numatune-memnode.xml |  2 +-
>  5 files changed, 10 insertions(+), 12 deletions(-)
> 

ACK - and I see the VIR_FREE(tmp) from 3/24 appears in the right place
now ;-)

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]