Re: [RFC] [Patch] Make hugepage testcase arch-agnostic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 02, 2015 at 09:41:33AM +0100, Ján Tomko wrote:
> On Mon, Feb 02, 2015 at 01:16:31PM +0530, Prerna Saxena wrote:
> > Hi,
> > I have attached this patch as a response to a recent failure observed on PowerPC architecture by commit
> > 311b4a67.
> > This patch introduces a check for dynamically obtaining system page size for test hugepages-pages6 under 'qemuxml2argv' suite. ( See patch for more verbose problem description)
> > This patch is not the most perfect implementation -- it fails syntax check; and has a Makefile-driven cleanup pending. I will be happy to deck it up and send it if the community concurs with this
> > approach.
> > 
> > We could also implement this via a shell script ( just like 'virt-test-aa-helper')  but I couldnt find an easy way to determine host page size.
> > 
> > Awaiting community responses,
> > Prerna
> > 
> 
> My preferred solution would be separating all the sysconf(_SC_PAGESIZE)
> calls into some virGetSystemPageSize helper and mocking it in
> qemuxml2argvmock.c, always returning 4 KB.

I've got a change doing exactly that which I'm in middle of testing.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]