On Mon, Feb 02, 2015 at 01:16:31PM +0530, Prerna Saxena wrote: > Hi, > I have attached this patch as a response to a recent failure observed on PowerPC architecture by commit > 311b4a67. > This patch introduces a check for dynamically obtaining system page size for test hugepages-pages6 under 'qemuxml2argv' suite. ( See patch for more verbose problem description) > This patch is not the most perfect implementation -- it fails syntax check; and has a Makefile-driven cleanup pending. I will be happy to deck it up and send it if the community concurs with this > approach. > > We could also implement this via a shell script ( just like 'virt-test-aa-helper') but I couldnt find an easy way to determine host page size. > > Awaiting community responses, > Prerna > My preferred solution would be separating all the sysconf(_SC_PAGESIZE) calls into some virGetSystemPageSize helper and mocking it in qemuxml2argvmock.c, always returning 4 KB. Jan > >From 8a64d4d22e2e65158d3caa45b615ca9a263f841f Mon Sep 17 00:00:00 2001 > From: Prerna Saxena <prerna@xxxxxxxxxxxxxxxxxx> > Date: Mon, 2 Feb 2015 10:48:48 +0530 > Subject: [PATCH] Commit 311b4a67 introduces a test for normal-page backed > guest XML. However, it hardcodes the page size to 4 KB which is only valid > for Intel Make check consequently fails on PowerPC where page size is 64KB > > This makes the hugepages-pages6 test more modular, and enables the page size > to be picked up at runtime. > --- > .../qemuxml2argv-hugepages-pages6.template | 32 ++++++++++++++++++++++ > tests/qemuxml2argvtest.c | 24 +++++++++++++++- > 2 files changed, 55 insertions(+), 1 deletion(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hugepages-pages6.template >
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list