According to xm.config manual, HVM pae|apic|acpi feature default
is 1 (enabled). But in conversion from xm config to libvirt xml,
if xm config doesn't contain pae|apic|acpi, it sets default value
to 0, this causes some problems in HVM guest.
Update parser codes to set HVM pae|apic|acpi default value to 1
to match xm config convension.
Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx>
---
src/xenconfig/xen_common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c
index 25bdf26..221509a 100644
--- a/src/xenconfig/xen_common.c
+++ b/src/xenconfig/xen_common.c
@@ -512,17 +512,17 @@ xenParseCPUFeatures(virConfPtr conf, virDomainDefPtr def)
return -1;
if (STREQ(def->os.type, "hvm")) {
- if (xenConfigGetBool(conf, "pae", &val, 0) < 0)
+ if (xenConfigGetBool(conf, "pae", &val, 1) < 0)
return -1;
else if (val)
def->features[VIR_DOMAIN_FEATURE_PAE] = VIR_TRISTATE_SWITCH_ON;
- if (xenConfigGetBool(conf, "acpi", &val, 0) < 0)
+ if (xenConfigGetBool(conf, "acpi", &val, 1) < 0)
return -1;
else if (val)
def->features[VIR_DOMAIN_FEATURE_ACPI] = VIR_TRISTATE_SWITCH_ON;
- if (xenConfigGetBool(conf, "apic", &val, 0) < 0)
+ if (xenConfigGetBool(conf, "apic", &val, 1) < 0)
return -1;
else if (val)
--
1.8.4.5
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list