On Mon, Oct 27, 2014 at 6:17 AM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
> On Fri, Oct 24, 2014 at 04:28:14PM -0400, Conrad Meyer wrote:
>> docs/drvbhyve.html.in | 28 ++++++-
>> docs/formatdomain.html.in | 4 +-
>> po/libvirt.pot | 4 +
>> src/bhyve/bhyve_command.c | 204 ++++++++++++++++++++++++++++++++++++++++++----
>> src/bhyve/bhyve_driver.c | 5 ++
>> src/bhyve/bhyve_process.c | 5 ++
>> src/bhyve/bhyve_utils.h | 1 +
>> 7 files changed, 228 insertions(+), 23 deletions(-)
>
> Could you also add to tests/bhyvexml2argv{data/,test.c} so that you
> exercise the new code paths in tests.
Okay.
>> diff --git a/po/libvirt.pot b/po/libvirt.pot
>> index 0b44ad7..d8c9a4d 100644
>> --- a/po/libvirt.pot
>> +++ b/po/libvirt.pot
>> @@ -851,6 +851,10 @@ msgstr ""
>> msgid "domain should have at least one disk defined"
>> msgstr ""
>>
>> +#: src/bhyve/bhyve_command.c:407
>> +msgid "Custom loader requires explicit %s configuration"
>> +msgstr ""
>> +
>> #: src/bhyve/bhyve_device.c:50
>> msgid "PCI bus 0 slot 1 is reserved for the implicit LPC PCI-ISA bridge"
>> msgstr ""
>
> You can drop this chunk - we manually update the .pot file before release
> and when pushing to our translation system.
Sure.
Thanks,
Conrad
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list