Re: [PATCH v2 2/3] nodedev: move pci express types to virpci.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/24/2014 04:03 AM, Martin Kletzander wrote:
> On Wed, Jul 23, 2014 at 09:06:07PM -0600, Eric Blake wrote:
>> Finding virPCIE* code is more intuitive if located in virpci.h
>> instead of node_device_conf.h.
>>

>> +struct _virPCIEDeviceInfo {
>> +    /* Not all PCI Express devices has link. For example this 'Root
>> Complex
> 
> I know it's pre-existing, but reading "devices has link" makes the
> back of my head itch, shouldn't it be 'have'?  Could you change it if
> I am right?

You are right; 'all ... devices' is plural, so it should pair with
'have'.  Fixed, and series pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]