On Mon, Nov 24, 2008 at 11:44:15AM -0500, David Lively wrote: > On Mon, 2008-11-24 at 17:30 +0100, Jim Meyering wrote: > > David Lively <dlively@xxxxxxxxxxxxxxx> wrote: > > > On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: > > >> David Lively <dlively@xxxxxxxxxxxxxxx> wrote: > > >> > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > > >> > I'm printing the (user-supplied) object names to help in debugging > > >> > misbehaving python EventImpls (since there's no static type checking to > > >> > catch these kinds of things). So instead of printing "<NULL>" when we > > >> > can't alloc the name, I'm printing something a little more helpful (the > > >> > appropriate "generic" name). > > >> > > >> That's better, indeed. > > >> I prefer your NAME macro, too. > > >> ACK, modulo syntax: > > >> > > > ... > > > > > >> Reversed diff? Better to split long lines, > > >> not to join. > > > > > > Ok. Fixed in attached patch. > > > > > >> > + <<< > > >> > > >> Trailing white space ^^. > > > > > > .. along with this one ... and the trailing whitespace on line 1982. > > > > > > *This* time I ran syntax-check :-) > > > > ;-) > > Unqualified ACK, then, assuming those are the only changes. > > Those are the only changes. Ok, I committed this patch now. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list