On Fri, Nov 21, 2008 at 02:14:57PM -0500, David Lively wrote: > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > > No big deal, but there are several debug printf uses here that look > > like they try to print NULL pointers upon memory allocation failure. > > It's ok with glibc's printf of course, but not for others. > > You're right. Attached patch fixes those issues. It also fixes some > cases in which I got some printf string operands switched around ... > > I'm printing the (user-supplied) object names to help in debugging > misbehaving python EventImpls (since there's no static type checking to > catch these kinds of things). So instead of printing "<NULL>" when we > can't alloc the name, I'm printing something a little more helpful (the > appropriate "generic" name). ACK. This looks ok to me now. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list