Re: [PATCH 1/2] Refactor virMutexInit virRWLockInit and virCondInit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- Original Message -----
> After your patch 2, do we really have any callers that use the quiet
> version? This seems like the sort of patch where ALL callers should be
> noisy (especially since the failure is so rare, but also means we are
> quite hosed if it happens).  What are the callers that you intend to be
> quiet, and what is the justification for them being quiet?

Eric, yes, if mutex initialization fails, it is very fatal to libvirt,
and I can't give an example for quiet version used. Maybe the 'quiet'
is not useful, and I will depart quiet from my next patch.

Thanks for your review.

> 
> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]