On 07/17/2014 10:49 PM, Jincheng Miao wrote: > Implement InitInternal functions for Mutex, RWLock and Cond, these functions > contain error report using virReportSystemErrorFull, it is controlled by > an argument 'quite'. > The related macros are Init and InitQuite, they call InitInternal function > by passing 'false' or 'true' to quite argument. After your patch 2, do we really have any callers that use the quiet version? This seems like the sort of patch where ALL callers should be noisy (especially since the failure is so rare, but also means we are quite hosed if it happens). What are the callers that you intend to be quiet, and what is the justification for them being quiet? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list