On Wed, Nov 05, 2008 at 02:53:19PM +0100, Jim Meyering wrote: > Without this patch, running make check would trigger this minor leak: > > 10 bytes in 1 blocks are definitely lost in loss record 1 of 20 > at 0x4A0739E: malloc (vg_replace_malloc.c:207) > by 0x3F872808A1: strdup (strdup.c:43) > by 0x4CA2503: qemudLoadDriverConfig (qemu_conf.c:70) > by 0x4CA7EA7: qemudStartup (qemu_driver.c:216) > by 0x4C3AEBC: __virStateInitialize (libvirt.c:592) > by 0x4096B6: qemudInitialize (qemud.c:738) > by 0x40CCCF: main (qemud.c:2216) > > Looking into it, I found there were actually two separate leaks > and an erroneous diagnostic. This fixes them: The patch looks fine to me, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list