On Thu, Aug 28, 2008 at 09:53:57AM +0100, Daniel P. Berrange wrote:
> On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote:
> > > The biggest flaw I see currently is that the
> > >openvz driver doesn't load the existing device config for networks or
> > >filesystems of existing VMs, so you can't see that info in the XML dump
> > Yes. Good note. I will implement it.
> > >
> >
> > >- /*get VCPU*/
> > >- ret = openvzReadConfigParam(veid, "CPUS", temp, sizeof(temp));
> > >- if (ret < 0) {
> > >- openvzError(conn, VIR_ERR_INTERNAL_ERROR,
> > >- _("Cound not read config for container %d"),
> > >veid);
> > >- goto error;
> > >- } else if (ret > 0) {
> > >- vmdef->vcpus = strtoI(temp);
> > >- }
> > Why did you remove loading VCPUs and always set = 1 ?
>
> Stupid mistake during a manual merge. Here's an updated patch which
> fixes that mistake
Fine by me, if Evgeniy is okay with it, let's commit this once Jim's
comments are taken into account.
I just wishes patch could learn about function boundaries instead
of cherry picking pieces left and right to generate the new output,
+1
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list