On Wed, Jul 30, 2008 at 06:04:23AM -0400, Daniel Veillard wrote: > On Wed, Jul 30, 2008 at 10:56:48AM +0100, Richard W.M. Jones wrote: > > On Wed, Jul 30, 2008 at 05:43:44AM -0400, Daniel Veillard wrote: > > > Hum, I would check for basic well-formedness here because it just > > > too easy to break the XML file while editing with a text editor > > > > But the subsequent call to virDomainDefineXML should fail if the XML > > isn't well-formed. > > Right, but you're taking a risk and not giving a chance for the > user to escape while being safe. As it stands, this is the error message that users get if they edit the XML so that it is not well-formed: # virsh edit RHEL5U2 libvir: QEMU error : XML description not well formed or invalid and the XML isn't changed. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 59 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list