On Wed, Jul 30, 2008 at 10:56:48AM +0100, Richard W.M. Jones wrote: > On Wed, Jul 30, 2008 at 05:43:44AM -0400, Daniel Veillard wrote: > > Hum, I would check for basic well-formedness here because it just > > too easy to break the XML file while editing with a text editor > > But the subsequent call to virDomainDefineXML should fail if the XML > isn't well-formed. Right, but you're taking a risk and not giving a chance for the user to escape while being safe. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list