On Sun, Mar 23, 2008 at 07:50:24PM +0100, Guido Günther wrote: > This patch marks the error messages in qemu_driver.c as translatable, > some of them were marked as such already. Please apply. [...] > qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, > - "cannot create bridge '%s' : %s", name, strerror(err)); > + _("cannot create bridge '%s' : %)"), name, strerror(err)); Patch is a bit broken here, otherwise that looks fine. I'm wondering why that wasn't check by 'make syntax-check' as other modules are checked for translatable strings. Applied and commited (after fixing the little issue before), thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list