S.Sakamoto wrote:
These struct definitions *intentionally* private.Oops, I did not notice it... I revised a patch not to access the struct data directly.
In principle this patch looks good. If no one else objects, I'll commit this, with a few of my own fixes (below).
Rich. + (obj->stringval) && !strcmp((char*)obj->stringval, "hvm")) I'm going to use STREQ macro here instead of !strcmp. + if (ctxt) + xmlXPathFreeContext(ctxt);There are a few potential double-frees on the cleanup path. Need to set ctxt back to NULL after freeing it.
-- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
-- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list