On Mon, Dec 03, 2007 at 02:43:30PM +0000, Richard W.M. Jones wrote: > Jim Meyering wrote: > >Without this patch, building without HAVE_AVAHI fails due to an unguarded > >use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > >and less maintainable), I've chosen to un-ifdef the declarations and > >a few uses. The more code that we compile and use unconditionally, > >the fewer surprises we'll encounter down the road. > > Strangely enough I didn't hit this problem when building on Cygwin, and > I'm pretty sure they don't have avahi? > > My only reservation is what happens if mdns_* configuration is in > libvirtd.conf, but there is no support in the binary. Should we print > out an error message or a warning? Its not worth the bother IMHO. You're adding extra code to cover one tiny niche case which will rarely ever be needed since all modern Linux have avahi. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list