On Mon, Dec 03, 2007 at 02:36:17PM +0100, Jim Meyering wrote: > Without this patch, building without HAVE_AVAHI fails due to an unguarded > use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > and less maintainable), I've chosen to un-ifdef the declarations and > a few uses. The more code that we compile and use unconditionally, > the fewer surprises we'll encounter down the road. I disagree - adding merely one extra HAVE_AVAHI in the cleanup code for that function won't hurt maintainability. I find it more confusing/suprising when I find variables which are there but not used in any code like mdns_adv vars are with this patch. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list