On 6/14/07, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
On Thu, Jun 14, 2007 at 05:06:16PM -0400, Mark Johnson wrote: > This is another patch which may not be popular? Xen's > extra version does not fit in libvirt's release field (since it's > part of an int). > > Instead of printing out the wrong value, just display > major.minor in virsh. Hmm, so with Xen we have two backend impls of the Version API, one talking to the hypervisor which only ever returns the first 2 components, and the other talking to XenD which processes all 3. As you say, in practice the extra version from Xen is effectively garbage So while as root I see # virsh version Compiled against library: libvir 0.2.2 Using library: libvir 0.2.2 Using API: Xen 3.0.1 Running hypervisor: Xen 3.1.0 If run as non-root I instead seee $ virsh version Compiled against library: libvir 0.2.2 Using library: libvir 0.2.2 Using API: Xen 3.0.1 Running hypervisor: Xen 3.730.259 I think instead of this patch to change the virsh driver though, we should change teh xend_internal.c file to ignore the extra_version data from XenD as there's no way to meaningfully interpret it as an int.
ah, I didn't check that one.. Maybe both? 3.1.0 could be incorrect. e.g. it could be 3.1.2. And certainly 3.730.259 is wrong :-) I suppose it could cheat and send a char or two in the rev? Mark.