On Thu, Aug 24, 2006 at 09:21:52AM -0400, Daniel Veillard wrote: > On Thu, Aug 24, 2006 at 02:07:51PM +0100, Daniel P. Berrange wrote: > > Quite a critical bit of the libvirt code is that which converts between > > SEXPR and XML, and vica-verca. I've broken this code several times when > > making changes, so it is way overdue to get some unit test coverage in > > this area. > > > > The attached patch adds such coverage - defining two tests xml2sexprtest > > and sexpr2xmltest. The tests are pretty simple, in the tests/ directory > > I just have a bunch of xml & sexpr files - one is the fixed input, the > > other is the expected output. The test just runs the conversion and compares > > the actual output with the expected output. Currently I've added two example > > data files - one for paravirt & one for fully-virt. With this patch you > > can run tests: > > > > $ make check > > make check-TESTS > > make[1]: Entering directory `/home/berrange/src/xen/libvirt/tests' > > XML-2-SEXPR PV config ... OK > > XML-2-SEXPR FV config ... OK > > PASS: xml2sexprtest > > SEXPR-2-XML PV config ... OK > > SEXPR-2-XML FV config ... OK > > PASS: sexpr2xmltest > > ================== > > All 2 tests passed > > ================== > > make[1]: Leaving directory `/home/berrange/src/xen/libvirt/tests' > > Excellent. Small suggestions: > - make tests/make check in the top level dir should also run it Urm - automake already hooks things up so if you type 'make check' in the top level, it runs 'make check' in all sub-directories. Why do we need to manually duplicate this with a 'make test' target ? > - adding a 'make valgrind' target running the same with valgrind -quiet Yes, good idea. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|