On Thu, Aug 24, 2006 at 02:07:51PM +0100, Daniel P. Berrange wrote:
> Quite a critical bit of the libvirt code is that which converts between
> SEXPR and XML, and vica-verca. I've broken this code several times when
> making changes, so it is way overdue to get some unit test coverage in
> this area.
>
> The attached patch adds such coverage - defining two tests xml2sexprtest
> and sexpr2xmltest. The tests are pretty simple, in the tests/ directory
> I just have a bunch of xml & sexpr files - one is the fixed input, the
> other is the expected output. The test just runs the conversion and compares
> the actual output with the expected output. Currently I've added two example
> data files - one for paravirt & one for fully-virt. With this patch you
> can run tests:
>
> $ make check
> make check-TESTS
> make[1]: Entering directory `/home/berrange/src/xen/libvirt/tests'
> XML-2-SEXPR PV config ... OK
> XML-2-SEXPR FV config ... OK
> PASS: xml2sexprtest
> SEXPR-2-XML PV config ... OK
> SEXPR-2-XML FV config ... OK
> PASS: sexpr2xmltest
> ==================
> All 2 tests passed
> ==================
> make[1]: Leaving directory `/home/berrange/src/xen/libvirt/tests'
Excellent. Small suggestions:
- make tests/make check in the top level dir should also run it
- adding a 'make valgrind' target running the same with valgrind -quiet
thanks
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/