On 4/23/19 2:34 AM, Fabiano Fidêncio wrote: > Altough there's no issue on using "=" with the test, let's standardize > on a single way to compare values, using "==". > > With that in mind, let's change "xHAVE_REQUESTS" = "xyes" to > "xHAVE_REQUESTS" == "xyes" instead. NACK. 'test .. == ..' is a bashism, the POSIX spelling is 'test .. = ..'. Various versions of dash fail on the bashism. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo