Re: [osinfo-db PATCH 1/1] Fix out-of-tree build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Guido,

On Thu, 2019-04-18 at 09:17 +0200, Guido Günther wrote:
> Hi,
> On Mon, Apr 15, 2019 at 12:11:49PM +0200, Fabiano Fidêncio wrote:
> > Let's set an ABS_TOPDIR and use it to run our tests, fixing then
> > the out-of-tree build.
> > 
> > https://gitlab.com/libosinfo/osinfo-db/issues/25
> > ---
> >  Makefile | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 4f6f8d4..a1bdcfe 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -52,6 +52,8 @@ INTLTOOL_MERGE_OPTS = $(INTLTOOL_MERGE_OPTS_$(V))
> >  INTLTOOL_MERGE_OPTS_0 = -q
> >  INTLTOOL_MERGE_OPTS_1 =
> >  
> > +ABS_TOPDIR := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))
> > +
> >  all: $(ARCHIVE) osinfo-db.spec mingw-osinfo-db.spec
> >  
> >  install: $(ARCHIVE)
> > @@ -121,4 +123,4 @@ update-po:
> >          done
> >  
> >  check: $(DATA_FILES) $(SCHEMA_FILES)
> > -	$(PYTHON) -m pytest
> > +	$(PYTHON) -m pytest $(ABS_TOPDIR)tests
> 
> Yes, the tests are found that way. I'm seeing lots of test failures
> though with
> 
> $ make -C build -f ../Makefile ARCHIVE=osinfo-db.tar.xz check

[snip]

I'm fully able to reproduce this issue and found another one (still
related to VPATH) while solving this.

I'll have a discussion with Cole later Today about how to properly
approach this issue.

Sorry for the headache caused by the changes we have done. :-(

Best Regards,
-- 
Fabiano Fidêncio

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux