On Tue, Nov 20, 2018 at 10:26:24AM +0100, Fabiano Fidêncio wrote: > The approach taken to fix the `make check` breakage is to export our > private symbols together with our public ones (under > LIBOSINFO_PRIVATE_$VERSION). I know libvirt does this already, but it has todo that for reasons other than the test suite - it exports its symbols to libvirtd. I'm not inclined todo this for libosinfo as it does have some annoying consequences, especially for automated tools that do ABI validation. I think the tests should just be statically linked to the libosinfo code via an intermediate convenience library. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
