Re: [libosinfo PATCH 0/2] Fix `make check` breakage on FreeBSD 11

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-11-20 at 10:26 +0100, Fabiano Fidêncio wrote:
> The approach taken to fix the `make check` breakage is to export our
> private symbols together with our public ones (under
> LIBOSINFO_PRIVATE_$VERSION).
> 
> Fabiano Fidêncio (2):
>   syms: "export" private syms
>   tests: Fix `make check` breakage on FreeBSD 11
> 
>  .gitignore                                       |  1 +
>  osinfo/Makefile.am                               | 12 ++++++++++++
>  osinfo/libosinfo_private.syms                    | 10 ++++++++++
>  osinfo/{libosinfo.syms => libosinfo_public.syms} |  0
>  tests/Makefile.am                                |  2 +-
>  5 files changed, 24 insertions(+), 1 deletion(-)
>  create mode 100644 osinfo/libosinfo_private.syms
>  rename osinfo/{libosinfo.syms => libosinfo_public.syms} (100%)
> 

Self-NACK + Andrea's NACK!
It doesn't work for VPATH based builds and I'll submit a v2 soon.

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux