Re: [osinfo-db PATCH] debian: fix architecture names to match schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 07, 2017 at 04:23:53PM +0200, Pino Toscano wrote:
> On Friday, 7 July 2017 15:59:39 CEST Guido Günther wrote:
> > On Fri, Jul 07, 2017 at 01:36:29PM +0200, Pino Toscano wrote:
> > > The schema has names for architectures which are closer to the RPM
> > > naming than the dpkg one -- thus, fix:
> > > - arm64 -> aarch64
> > > - armhf -> armv7l
> > 
> > Are the ones in libosinfo/tests/test-isodetect.c the right ones? Asking
> > since I intend to add all our architectures and flavours in the future
> > (once I get around to automate this).
> 
> Do you mean the various string findings in the "load_iso" function?
> To me, that looks more like an heuristic to guess the architecture of
> the test data based on its filename, rather than the 
> 
> One place with the canonical list of the architectures is in osinfo-db,
> data/schema/osinfo.rng.in, the "archnames" define.
> 
> PS: please remember to run `make check` in osinfo-db ;-)

Oh...didn't notice that we have that yet. Will do, the Debian package
just uploaded does this too now.

> 
> > [...]
> > 
> > ACK.
> >  -- Guido
> 
> Thanks! Can you please push it?

Done. Thanks!
 -- Guido

> 
> -- 
> Pino Toscano


_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux