Re: [PATCH v4 03/12] win8: Add comment about the user avatar issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 2, 2016 at 11:35 PM, Zeeshan Ali (Khattak)
<zeeshanak@xxxxxxxxx> wrote:
> Actually, isn't avatar installed by cmd file? If so, we don't really
> need to comment above the installer scripts that don't have anything
> to do with avatar. Maybe the comment should instead say why cmd file
> is not being included (assuming that's what we decide to do for now)?

I'd rather move the comment down, to be just above the cmd file.

>
> On Sun, May 1, 2016 at 10:57 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote:
>> From: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx>
>>
>> User avatar is not set as expected after performing a unattended
>> installation of Windows 8 (or newer).
>>
>> Signed-off-by: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx>
>> Acked-by: Zeeshan Ali (Khattak) <zeeshanak@xxxxxxxxx>
>> ---
>>  data/os/microsoft.com/win-8.xml.in | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/data/os/microsoft.com/win-8.xml.in b/data/os/microsoft.com/win-8.xml.in
>> index 50a1a31..e31bce9 100644
>> --- a/data/os/microsoft.com/win-8.xml.in
>> +++ b/data/os/microsoft.com/win-8.xml.in
>> @@ -51,6 +51,11 @@
>>        <device id="http://pcisig.com/pci/8086/2668"/> <!-- ICH6 -->
>>      </devices>
>>
>> +    <!--
>> +        User avatar not being set for Windows 8 (or newer).
>> +        For more details, please, see:
>> +        https://bugzilla.redhat.com/show_bug.cgi?id=1328637
>> +    -->
>>      <installer>
>>        <script id='http://microsoft.com/windows/unattend/jeos'/>
>>        <script id='http://microsoft.com/windows/unattend/desktop'/>
>> --
>> 2.7.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo@xxxxxxxxxx
>> https://www.redhat.com/mailman/listinfo/libosinfo
>
>
>
> --
> Regards,
>
> Zeeshan Ali (Khattak)
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Fabiano Fidêncio

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux