Re: [PATCH v4 02/12] win8: Add missing cmd script for installer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 2, 2016 at 11:33 PM, Zeeshan Ali (Khattak)
<zeeshanak@xxxxxxxxx> wrote:
> Hi,
>
> Cmd file mainly installs spice-guest-tools and that doesn't work for
> windows >= 8. As you already mentioned, the avatar doesn't get
> installed correctly either so I'm wondering about the usefulness of
> this patch, as is.

Well, at first I thought the avatar was not working because of this
missing line and I had to include it, test it and then realize it's
not working for any other reason that we don't know yet.
So, I don't know, but IMO is better to have everything set as it is
expected for a working unattended-installation (it could have saved me
some time), mainly because it doesn't cause any harm.

>
> On Sun, May 1, 2016 at 10:57 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote:
>> From: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx>
>>
>> Signed-off-by: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx>
>> ---
>>  data/os/microsoft.com/win-8.xml.in | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/data/os/microsoft.com/win-8.xml.in b/data/os/microsoft.com/win-8.xml.in
>> index d20b239..50a1a31 100644
>> --- a/data/os/microsoft.com/win-8.xml.in
>> +++ b/data/os/microsoft.com/win-8.xml.in
>> @@ -54,6 +54,7 @@
>>      <installer>
>>        <script id='http://microsoft.com/windows/unattend/jeos'/>
>>        <script id='http://microsoft.com/windows/unattend/desktop'/>
>> +      <script id='http://microsoft.com/windows/cmd/desktop'/>
>>      </installer>
>>    </os>
>>  </libosinfo>
>> --
>> 2.7.3
>>
>> _______________________________________________
>> Libosinfo mailing list
>> Libosinfo@xxxxxxxxxx
>> https://www.redhat.com/mailman/listinfo/libosinfo
>
>
>
> --
> Regards,
>
> Zeeshan Ali (Khattak)
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Fabiano Fidêncio

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux