On Thu, Apr 18, 2013 at 12:57:49PM +0200, Christophe Fergeau wrote: > On Wed, Apr 17, 2013 at 06:59:10PM +0300, Zeeshan Ali (Khattak) wrote: > > ACK. Although these patches adds a lot of lines, I think they should > > still qualify as trivial especially when its from a person with commit > > access. Just my two cents. > > Given that the OS database is probably the part of libosinfo that has seen > the most bugs[1], I don't consider them as trivial and I think they should > go through review first. Oh, after rereading this, maybe we are not talking of the same thing. I'm talking about additions to data/oses, but maybe you were talking about commits only adding new files to tests/isoinfo/ ? I agree that the latter can be seen as a trivial patch as long as make check still passes after the commit. Christophe
Attachment:
pgpvLCmF_EV6A.pgp
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
