On Thu, Feb 28, 2013 at 2:34 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Thu, Feb 28, 2013 at 02:14:52PM +0200, Zeeshan Ali (Khattak) wrote: >> On Thu, Feb 28, 2013 at 11:25 AM, Christophe Fergeau >> <cfergeau@xxxxxxxxxx> wrote: >> > On Wed, Feb 27, 2013 at 04:20:33PM +0200, Zeeshan Ali (Khattak) wrote: >> >> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> >> >> >> >> Sometimes we'll have a lot in common between rather long templates of >> >> different OSs. To be able to share the templates, we need a way to >> >> include templates from one XML file to another. >> >> >> >> XInclude[1] is the way we achieve that. >> > >> > NACK, https://www.redhat.com/archives/libosinfo/2013-February/msg00118.html >> > still stands (and yes I've seen >> > https://www.redhat.com/archives/libosinfo/2013-February/msg00139.html ) >> >> A NACK without any indication of how to solve the problem at hand, >> isn't very helpful. :) > > https://www.redhat.com/archives/libosinfo/2013-February/msg00118.html has > indications of what could be a better way of handling the xi:include. You > resending your initial patch without indication of *why* you resend it > unchanged is not helpful. Are you resending it because you think the > initial approach was better than what I suggested? If yes, why? Do you > agree that the approach I suggested is better but you hit a roadblock and > would like some help solving it? I don't know anything about all of that, I > just know that you tried a different approach, didn't manage to get it to > work, and now you are resending your first patch, so my only option is > NACKing it in the hope of getting my initial review comments addressed. You suggested a better way and since I informed you that I tried that without arguing against it, it should be obvious that I agreed with you. Also since I informed you that I tried it and then I resend the original patch, what other possibility remains than "I tried, failed and will want to keep this patch unless you can help me out in making it better"? -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
