On Sat, Dec 29, 2012 at 2:02 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Sat, Dec 29, 2012 at 01:39:58AM +0200, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> >> >> RHEL6 requires 512MB, not 256 as per documentation: >> >> http://www.redhat.com/resourcelibrary/articles/articles-red-hat-enterprise-linux-6-technology-capabilities-and-limit >> >> Thanks to Christophe Fergeau for pointing this one out as well. >> >> Pushed under trivial rule. > > NACK, this only addresses half of the review comments. The only other comment it doesn't address was "I'd also set recommended to 1GB." which sounds like more a light suggestion and since the recommended memory *is* already 1GB, I didn't see what I was supposed to do. Feel free to provide a patch to improve these! > As this is the 3rd time in a row one of your 'pushed under trivial rule' > patches need work, please think twice in the future before pushing > something under this rule. As long as it doesn't break anything, things can always be improved. No need to have long discussion about such small matters. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
