Re: [PATCH] - func/minion/modules/yumcmd.py: should do a ayum.update() when yumcmd update called without pattern. Just swapped the tx_result inside the if control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yes, I thought about it after to send my patch ... 
and thanks to fix my english on the commit message !

Seth Vidal wrote:
> 
> 
> On Tue, 18 May 2010, Gael Chamoulaud wrote:
> 
> >---
> >func/minion/modules/yumcmd.py |    4 ++--
> >1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/func/minion/modules/yumcmd.py b/func/minion/modules/yumcmd.py
> >index 17d8fcb..1b96fdb 100644
> >--- a/func/minion/modules/yumcmd.py
> >+++ b/func/minion/modules/yumcmd.py
> >@@ -32,9 +32,9 @@ class Yum(func_module.FuncModule):
> >        try:
> >            ayum.doLock()
> >            if pkg in [None, '']:
> >-                tx_result = ayum.update(pattern=pkg)
> >-            else:
> >                tx_result = ayum.update()
> >+            else:
> >+                tx_result = ayum.update(pattern=pkg)
> >
> >            ayum.buildTransaction()
> >            ayum.processTransaction(
> >--
> 
> 
> Gael - thanks for the patch. I just added a 'not' to the if
> statement which does the same thing but with only a one line patch.
> 
> Thank you for catching this.
> 
> -sv
> 

-- 
--------------------------------------------------------------
-- Gaël Chamoulaud (Strider)
-- Own Phone: +33 (0)6 87 71 47 85
-- Work Phone: +33 (0)6 45 17 75 29
-- Gnome: <strider at gnome dot org>
-- Gmail: <gael dot chamoulaud at gmail dot com>
-- Work: <gael dot chamoulaud at aramice dot fr>
--
-- "La bière est la preuve que Dieu nous aime et veut 
-- que nous soyons heureux." [Benjamin Franklin]
-- 
-- ()  ascii ribbon campaign - against html e-mail 
-- /\  www.asciiribbon.org   - against proprietary attachments
--------------------------------------------------------------

_______________________________________________
Func-list mailing list
Func-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/func-list


[Index of Archives]     [Fedora Users]     [Linux Networking]     [Fedora Legacy List]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux