Re: [PATCH] - func/minion/modules/yumcmd.py: should do a ayum.update() when yumcmd update called without pattern. Just swapped the tx_result inside the if control

Seth Vidal <skvidal@xxxxxxxxxxxxxxxxx> · Tue, 18 May 2010 08:29:27 -0400 (EDT)

On Tue, 18 May 2010, Gael Chamoulaud wrote:

---
func/minion/modules/yumcmd.py |    4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/func/minion/modules/yumcmd.py b/func/minion/modules/yumcmd.py
index 17d8fcb..1b96fdb 100644
--- a/func/minion/modules/yumcmd.py
+++ b/func/minion/modules/yumcmd.py
@@ -32,9 +32,9 @@ class Yum(func_module.FuncModule):
        try:
            ayum.doLock()
            if pkg in [None, '']:
-                tx_result = ayum.update(pattern=pkg)
-            else:
                tx_result = ayum.update()
+            else:
+                tx_result = ayum.update(pattern=pkg)

            ayum.buildTransaction()
            ayum.processTransaction(
--


Gael - thanks for the patch. I just added a 'not' to the if statement 
which does the same thing but with only a one line patch.

Thank you for catching this.

-sv

_______________________________________________
Func-list mailing list
Func-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/func-list




