Hi guys !
The patch seems too work (for the time being) well, but only if your
minions are on 2.3, for the overlord there is also (at least) another
minor change :
diff --git a/func/overlord/client.py b/func/overlord/client.py
index b9f8d76..a96a9e3 100644
--- a/func/overlord/client.py
+++ b/func/overlord/client.py
@@ -19,7 +19,10 @@ import glob
import os
import time
import shlex
-import subprocess
+try :
+ import subprocess
+except ImportError :
+ from func.minion import sub_process as subprocess
import re
import fnmatch
import func.yaml as yaml
I don't know if it is enough because my overlord is running on python
2.4, I saw the error by doing a
func --version
Traceback (most recent call last):
File "/usr/bin/func", line 23, in ?
import func.overlord.func_command as func_command
File "/usr/lib/python2.3/site-packages/func/overlord/func_command.py",
line 19, in ?
from func.overlord import client,base_command
File "/usr/lib/python2.3/site-packages/func/overlord/client.py", line
22, in ?
import subprocess
ImportError: No module named subprocess
So, it an easy patch for that.
I think, the sub_process being useful for the minion AND (from now) the
overlord part, it should be extracted from minion and moved to the same
level as utils.py and jobthing.py
By the way, I got another patch to submit here, the yumcmd module has
several indentation errors ...
diff --git a/func/minion/modules/yumcmd.py
b/func/minion/modules/yumcmd.py
index b615ce2..17d8fcb 100644
--- a/func/minion/modules/yumcmd.py
+++ b/func/minion/modules/yumcmd.py
@@ -25,7 +25,7 @@ class Yum(func_module.FuncModule):
description = "Package updates through yum."
def update(self, pkg=None):
- import yum
+ import yum
ayum = yum.YumBase()
ayum.doGenericSetup()
ayum.doRepoSetup()
@@ -53,7 +53,7 @@ class Yum(func_module.FuncModule):
if type(filter) not in [list, tuple]:
filter = [filter]
- import yum
+ import yum
ayum = yum.YumBase()
ayum.doConfigSetup()
ayum.doTsSetup()
I didn't took the time to see if there was other ways of doing things
but posting here, sorry if it's not good, but I think this is better
that doing things my side and keeping it.
Have a nice day !
Nicolas Di Pietro
-----Original Message-----
From: func-list-bounces@xxxxxxxxxx [mailto:func-list-bounces@xxxxxxxxxx]
On Behalf Of Seth Vidal
Sent: Monday, March 29, 2010 10:52 PM
To: Andreas Thienemann
Cc: func-list@xxxxxxxxxx
Subject: Re: Support broken for python2.3 (and RHEL 4) ?
On Tue, 16 Mar 2010, Andreas Thienemann wrote:
> On 03/16/2010 09:18 AM, External DI PIETRO Nicolas (CAMPUS) wrote:
>
>> The question is, is func meant to be run on python2.3 or does the
>> support for (old) python2.3 dropped ?
>
> I do not know if it is intentional but with 0.25 python 2.3 support
broke.
>
> Attached is a patch which will add python 2.3 support. We are applying
> it inside our .spec file:
>
> %if 0%{?rhel} == 4
> %patch3 -p1 -b .py23
> %endif
>
> The patch might be a bit hackish and I would not suggest using it on
> machines which have a python 2.4 package installed. Otherwise however,
it works fine.
>
applied and pushed.
-sv
_______________________________________________
Func-list mailing list
Func-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/func-list
_______________________________________________
Func-list mailing list
Func-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/func-list
