Re: [PATCH] fix create method on virt module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Luca Foppiano wrote:
On Thu, 2008-05-22 at 15:45 -0400, Michael DeHaan wrote:
Luca Foppiano wrote:
Hi all, create method on virt module doesn't work on xen domain based
machines because findByName connection method fails (XEN can see shutoff
virtual machines).

I add a simple code to use "xm create 'machinename'" to permit starting
machines by using machine name.

Here my patch :)


Luca



Thanks for the interest and patch, though this will not be applied.

There are libvirt API's for browsing inactive machines and starting them -- virt-manager uses them -- and that's the way this should be done. We will not be using Xen xm commands for Func because libvirt provides us with a useful abstraction layer that is more programatically oriented.

I don't recall this support being busted but this is something I can look at and retest next week.

I tried to search them, but I didn't find anything useful: which
function are you speak about?

I think this patch can be useful on RHEL installation where libvirt is
not up-to-date with the last version.

Luca

Ok, given you were testing this on something that wasn't up to date, can you share what that was?

If it's just a RHEL4uX machine that hasn't recieved the latest up2date updates, we can safely say that one needs
to get those updates.

If we're talking about something that isn't the latest revision, that's a bit different... though with virt, we'd strongly want
people to be running something semi-current.

The virt module in question was originally written for RHEL 5.0 and Fedora 8, and should be fine for those and beyond.
I would expect RHEL 4u6 to also work.

I suspect the problem is that the find_vm calls in older versions do not support inactive domains, in which case they really do need to upgrade their libvirt as a lot more than just create wouldn't be usable. Namely, the VMs wouldn't show up
in the list of domains that were available to start, right?

--Michael


_______________________________________________
Func-list mailing list
Func-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/func-list

[Index of Archives]     [Fedora Users]     [Linux Networking]     [Fedora Legacy List]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux