Re: CSS problem on wiki

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 26, 2010 at 4:11 PM, Sijis Aviles <sijis@xxxxxxxxxxxxxxxxx> wrote:
> On Mon, Jul 26, 2010 at 3:46 PM, Paul W. Frields <stickster@xxxxxxxxx> wrote:
>> https://fedoraproject.org/wiki/User:Pfrields/Outline_test
>>
>> The page shows the problem, at least in my browser.  I have extensions
>> disabled and the CSS is rendering third-level headings as inline
>> elements instead of block.
>>
>> --
>> Paul W. Frields                                http://paul.frields.org/
>>  gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233  5906 ACDB C937 BD11 3717
>>  http://redhat.com/   -  -  -  -   http://pfrields.fedorapeople.org/
>>          Where open source multiplies: http://opensource.com
>> --
>> websites mailing list
>> websites@xxxxxxxxxxxxxxxxxxxxxxx
>> https://admin.fedoraproject.org/mailman/listinfo/websites
>>
>
> You are right. This is due to the fedora.css inheritance on fp.o. In
> fedora.css, line 151 says "display: block-inline" and that's to allow
> the most-compatible/fedora-default text to work.
>
> In either case, this commit in fedora-web "52ad4f79" breaks it.
>
> In most cases, i don't think there will be multiple h3's in a row
> without text in between it.
> Either way, it should be fixed. I'll add a class to that
> most-compatible/fedora default text and tag block:display-inline to
> that.
>
> Sijis
>

I'm attaching the patch.

Let me know if this works OK and doesn't break fp.o or wiki before committed.

Thanks,

Sijis
diff --git a/fedoraproject.org/data/content/get-fedora-options.html b/fedoraproject.org/data/content/get-fedora-options.html
index fbff803..353960b 100644
--- a/fedoraproject.org/data/content/get-fedora-options.html
+++ b/fedoraproject.org/data/content/get-fedora-options.html
@@ -58,7 +58,7 @@
 				<h2>${_('Fedora Desktops')}</h2>
 				<p>${_('There are multiple desktops available for use with Fedora. Each has a slightly different look and feel and offers varying levels of customization. Desktops affect how windows, icons, menus, and various basic desktop interfaces look and feel. You may want to try a few different ones and figure out which one is best for you!')}</p>
 				<span class="desktop-section">
-					<h3>${_('Fedora 13 Desktop Edition')}</h3><span class="star-fedora-default">${_('Fedora Default')}</span>
+					<h3 class="area-callout">${_('Fedora 13 Desktop Edition')}</h3><span class="star-fedora-default">${_('Fedora Default')}</span>
 					<table>
 						<tbody>
 							<tr>
@@ -183,7 +183,7 @@
 				<h2>${_('Fedora Downloads by Architecture')}</h2>
 				<p>${Markup(_('Not sure which of these architectures are right for you? Need help figuring out what a particular computer\'s architecture is? We\'ve &lt;a href="http://docs.fedoraproject.org/install-guide/f13/en-US/html/ch-new-users.html#sn-which-arch"&gt;got a helpful guide&lt;/a&gt;.'))}</p>
 				<span class="arch-section">
-					<h3>${_('PC-Compatible')} <span>${_(' 32-bit')}</span></h3><span class="star-most-compatible">${_('Most Compatible')}</span>
+					<h3 class="area-callout">${_('PC-Compatible')} <span>${_(' 32-bit')}</span></h3><span class="star-most-compatible">${_('Most Compatible')}</span>
 					<p>${_('Because they run on both 32-bit and 64-bit Intel and AMD-compatible PCs, the 32-bit PC-compatible versions of Fedora are the most versatile.')}</p>
 					<span class="download-option opt1">
 						<h4>${_('Fedora 13 Desktop Edition')}</h4>
diff --git a/fedoraproject.org/static/css/fedora.css b/fedoraproject.org/static/css/fedora.css
index 0777852..7693df0 100644
--- a/fedoraproject.org/static/css/fedora.css
+++ b/fedoraproject.org/static/css/fedora.css
@@ -153,7 +153,6 @@ abbr, acronym {
   color: #337acc;
   margin: 1.5ex 0 0.5ex;
   font-size: 1.4em;
-  display: inline-block; /* to put icons next to header */
 }
 
 #content h3.header {
@@ -1122,6 +1121,11 @@ div.panes span.opt2 {
 
 .shownojs { display: none; }
 
+.area-callout
+{
+  display: inline-block; /* to put icons next to header */
+}
+
 /* end: get-option common */
 
 /* get-option - desktop pane */
-- 
websites mailing list
websites@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/websites

[Index of Archives]     [Fedora Users]     [Linux ARM]     [ARM Kernel]     [Older Fedora Users]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [Asterisk PBX]

  Powered by Linux