Dimitris Glezos wrote:
O/H Karsten Wade έγραψε:
On Sun, 2007-03-25 at 22:18 -0500, Mike McGrath wrote:
Beyond that I
wanted to state my concerns with this patch. If we can get this
incorporated upstream, I think it's great. If not my concern is ongoing
maintenance. It's never a fun thing to keep a local fork up to date.
I'll leave it entirely up to the websites team but I wanted to point out
that there are steep requirements long term with this patch which may
muck with future upgrades and I want to make sure everyone considers it
for an aesthetic change.
If the code is reasonable to maintain, there is a good chance upstream
will accept it, I think.
Upstream discussion takes place here:
http://moinmoin.wikiwikiweb.de/FeatureRequests/MoveButtonBarBelowCommentBox
We seem to disagree on what produces higher accessibility. Nevertheless, I will
follow the discussion.
I would like to apply the patch and re-discuss it (if needed) when we upgrade.
The patch is harmless and easily re-coded if upstream code changes.
I haven't applied this to our instance but will soon (unless one of the
other admins does it)
-Mike
