Re: Looking for people to trade reviews with.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 13, 2007 at 11:22:21PM +0200, Hans de Goede wrote:
> Michael E Brown wrote:
> >Hans,
> >
> >There were a couple of MUST items in the review guidelines that merit
> >discussion:
> >
> >- MUST: Header files must be in a -devel package.
> >  --> rpmlint also complains about this
> >- MUST: Static libraries must be in a -static package.
> >  --> rpmlint also complains about this
> >
> 
> These 2 are definitively not relevant for this package, see for example 
> also gcc, it includes .obj and .h files too, without putting them in a 
> seperate -devel package. If the packages sole purpose is to compile other 
> programs, putting bits of it in a -devel package is nonsense.
> 
> 
> >This package is a cross-compiled libc. Does it fall under these
> >guidelines? I dont see any specific guidance for cross-building tools.
> >
> 
> Notice that there are some WIP cross compiler packaging guidelines here:
> http://fedoraproject.org/wiki/Extras/SIGs/Embedded/CrossCompiling
> 
> But these badly need updating.
> 
> And as already said above, clearly it doesn't, because these guidelines do 
> not make any sense in the case of this package.

Ok. That is what I thought, too, but I thought it worth discussing.

I'll try to finish the review this weekend. Looking forward to seeing
this in the distro.
--
Michael

--
Fedora-maintainers mailing list
Fedora-maintainers@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-maintainers

--
Fedora-maintainers-readonly mailing list
Fedora-maintainers-readonly@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-maintainers-readonly

[Index of Archives]     [Fedora Users]     [Fedora Development]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux