On Tue, 2007-01-30 at 19:58 +0100, Till Maas wrote: > On Tuesday 30 January 2007 19:30, Ralf Corsepius wrote: > > > Yes, most packages link through the compiler and do not explicitly > > invoke the linker. Therefore, in most cases, linking also receives > > CFLAGS, which makes tweaking LDFLAGS unnecessary. > > > > In exotic cases (e.g. build-scripts), it can be necessary to also tweak > > LDFLAGS. > > So whenever linking is done whith gcc then it needs to be passed > $RPM_OPT_FLAGS ? Yes. Probably 99.9% of all existing Makefiles automatically do so. > Or how do I know whether or not to tweak LDFLAGS? By checking build logs. Normally you'll see build errors ("Missing symbols", "wrong architecture" or similar if something doesn't work. > If you like, please take a look into my package john, because I am not sure > whether or not LDFLAGS=$RPM_OPT_FLAGS are needed there but when I tested the > difference it seemed that even with LDFLAGS="" the stack protection worked. Ralf -- Fedora-maintainers mailing list Fedora-maintainers@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-maintainers -- Fedora-maintainers-readonly mailing list Fedora-maintainers-readonly@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-maintainers-readonly