Re: [OS-BUILD PATCH] redhat: set LC_ALL=C before sorting config content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Frantisek Hrbata on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2011#note_1098677827

The sorting is unstable, depending on the locale settings. IMHO this is wrong.
I don't understand what's the problem having it sorted according to C(having
the # disabled option first). Question is if the sorting is even needed. Note
I haven't looked the the perl merging scripts and if there is any dependency
on locale. If not I think we can just drop the sorting at all.

It can be simply verified that the outcome of the configs is the same. I
personally did this in rhel twice. Let's say you create container(C.UTF-8) for
building and run dist-git. You will end up with this sorting. Other maintainer
have en_US.UTF-8 and ends with different sorting. Usually you find out about
this only once you verify the dist-git diff. BTW at one stream we have this
sorting change in configs multiple times as the maintainers were alternating.

IMHO this is valid fix, but sure feel free to revert if you feel uncomfortable
with it.
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux