Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Thorsten Leemhuis on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948392278

> maybe it is just me, but a 'git log --oneline' shows 13 chars already.

Does it maybe depend on the repo? for my Linux mainline checkout I get 12; for
another git repo I get just 7. Upstream recommends hardcoding 12 via git
config: https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> I don't want the user experience to be "pass locally, but break in koji".

/me wonders when that might happen, but likely doesn't understand this because
he doesn't known enough about kernel-ark

Anyway: from a quick test it seems this patchset seems to solve my
"5.18.0-0.rc0.20220401gite8b767f5e04097a.15.vanilla.1.fc36.aarch64 exceeds 64
characters" problem (by dropping the date) that got me thinking about
shortening the sha1sum to 12 characters, so I don't care too much anymore. I'd
still say it would be nice to be more inline with what upstream does here by
using 12 chars, but it's not very important, so maybe lets just leave things
as they are.
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux