Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Don Zickus on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948374003

maybe it is just me, but a 'git log --oneline' shows 13 chars already.

git log --oneline   --abbrev=8|grep -Ev "^[0-9a-f]{,10} "

shows me 9 commits that are 11 chars long.

I am not sure how to autocheck what everyone's git tool is going to spit out
for length. We can hardcode 12, but if I am already on 13, then the check is
broken for my usage. I don't want the user experience to be "pass locally, but
break in koji". That would be frustrating.

I think we agreed on 15 as that would give us a couple of years, perhaps.  We
can make it more dynamic if we had the code and can spit out a good usage
message that said your git sha changed length or something.

I am up for ideas.
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux