On Fri, Feb 19, 2021 at 6:41 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi, > > On 2/8/21 2:36 PM, Hans de Goede wrote: > > Hi, > > > > On 2/7/21 4:48 PM, Justin Forbes wrote: > >> On Sat, Feb 6, 2021 at 5:39 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > >>> > >>> Hi, > >>> > >>> On 2/4/21 7:55 PM, Hans de Goede wrote: > >>>> Hi All, > >>>> > >>>> I'm sending out an email about this as I'm not 100% sure how to fix this. > >>>> > >>>> As a kernel-developer I usually build my own local kernels, since I'm also > >>>> a Fedora developer I try to keep the kernel .config of my local builds > >>>> synced with the Fedora kernel-configs. When grabbing the config from the > >>>> kernel-core-5.11.0-0.rc6.141.fc34.x86_64.rpm pkg and comparing it to > >>>> my local config I noticed this: > >>>> > >>>> # CONFIG_USB_RTL8152 is not set > >>> > >>> I upgraded to rawhide yesterday evening (I find it easiest to fix FTBFS > >>> errors when actually running rawhide) so now I'm running: > >>> > >>> 5.11.0-0.rc6.20210204git61556703b610.144.fc34.x86_64 > >>> > >>> And I can confirm that I no longer have working ethernet on my dock, > >>> can we get this fixed please ? (see below for root-cause analysis) > >>> > >> Thanks a ton for sending this. I killed the description block there so > >> it should be fixed for the rc7 build tomorrow. > > > > Thank you for fixing this. > > It seems that somehow this is not fixed though, after seeing this bug: > > https://bugzilla.redhat.com/show_bug.cgi?id=1930706 > > I checked the config in this build: > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1710935 > > And it still has: > > # CONFIG_USB_RTL8152 is not set > Oddly enough, the actual configs in dist-git show the line as: # CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not Which means it is definitely coming from that file. The part I find odd is I did clean that up in redhat/configs/fedora/generic/CONFIG_USB_RTL8153_ECM but not in redhat/configs/pending-common/generic/CONFIG_USB_RTL8153_ECM as the MR to set it outside of pending should do that. The config priority should be "ORDER=common pending-common fedora pending-fedora" which means the fedora value would override the pending common value, but the scripts must be based on exact match, and does not see one to flip it. Will clean up pending-common today and see if that clears it up. Thanks, Justin _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
