On Sat, Feb 6, 2021 at 5:39 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi, > > On 2/4/21 7:55 PM, Hans de Goede wrote: > > Hi All, > > > > I'm sending out an email about this as I'm not 100% sure how to fix this. > > > > As a kernel-developer I usually build my own local kernels, since I'm also > > a Fedora developer I try to keep the kernel .config of my local builds > > synced with the Fedora kernel-configs. When grabbing the config from the > > kernel-core-5.11.0-0.rc6.141.fc34.x86_64.rpm pkg and comparing it to > > my local config I noticed this: > > > > # CONFIG_USB_RTL8152 is not set > > I upgraded to rawhide yesterday evening (I find it easiest to fix FTBFS > errors when actually running rawhide) so now I'm running: > > 5.11.0-0.rc6.20210204git61556703b610.144.fc34.x86_64 > > And I can confirm that I no longer have working ethernet on my dock, > can we get this fixed please ? (see below for root-cause analysis) > Thanks a ton for sending this. I killed the description block there so it should be fixed for the rc7 build tomorrow. Thanks, Justin > > > > > And I immediately thought that can't be right, that is used in my > > Lenovo Thunderbolt docking station gen 2. > > > > It took me some digging to figure out what is going on here: > > > > [hans@x1 kernel-ark]$ pwd > > /home/hans/projects/kernel-ark > > [hans@x1 kernel-ark]$ find -name CONFIG_USB_RTL8152 > > ./redhat/configs/common/generic/CONFIG_USB_RTL8152 > > [hans@x1 kernel-ark]$ cat ./redhat/configs/common/generic/CONFIG_USB_RTL8152 > > CONFIG_USB_RTL8152=m > > > > That looks good, but is not what is in the rawhide-build, digging deeper > > finds this: > > > > [hans@x1 rawhide]$ pwd > > /home/hans/projects/fedora/kernel/rawhide > > [hans@x1 rawhide]$ grep CONFIG_USB_RTL8152 kernel-x86_64-fedora.config > > # CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not > > > > Which looks weird and then I found this, which explains everything: > > > > [hans@x1 kernel-ark]$ cat redhat/configs/fedora/generic/CONFIG_USB_RTL8153_ECM > > # CONFIG_USB_RTL8153_ECM: > > # > > # This option supports ECM mode for RTL8153 ethernet adapter, when > > # CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not > > # supported by r8152 driver. > > # > > # Symbol: USB_RTL8153_ECM [=m] > > # Type : tristate > > # Defined at drivers/net/usb/Kconfig:631 > > # Prompt: RTL8153 ECM support > > # Depends on: NETDEVICES [=y] && USB_NET_DRIVERS [=y] && USB_NET_CDCETHER [=m] && (USB_RTL8152 [=m] || USB_RTL8152 [=m]=n) > > # Location: > > # -> Device Drivers > > # -> Network device support (NETDEVICES [=y]) > > # -> USB Network Adapters (USB_NET_DRIVERS [=y]) > > # > > # > > # > > CONFIG_USB_RTL8153_ECM=m > > > > The script which is creating kernel-x86_64-fedora.config from all the CONFIG_FOO files is picking up the > > line from the comment block because the line matches the standard "# CONFIG_FOO is not set" template > > (with extra text at the end). > > > > Interestingly enough, I also see this: > > > > [hans@x1 kernel-ark]$ grep CONFIG_USB_RTL8152 redhat/configs/kernel-x86_64-fedora.config > > CONFIG_USB_RTL8152=m > > > > So on the kernel-x86_64-fedora.config in kernel-ark things are ok, > > but in the kernel-x86_64-fedora.config file in distgit, rawhide branch > > it is not ok ? I guess there is some difference in how these are generated ? > > > > Regards, > > > > Hans > > > > > > > > > _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
