On Mon, Feb 8, 2021 at 7:36 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi, > > On 2/7/21 4:48 PM, Justin Forbes wrote: > > On Sat, Feb 6, 2021 at 5:39 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > >> > >> Hi, > >> > >> On 2/4/21 7:55 PM, Hans de Goede wrote: > >>> Hi All, > >>> > >>> I'm sending out an email about this as I'm not 100% sure how to fix this. > >>> > >>> As a kernel-developer I usually build my own local kernels, since I'm also > >>> a Fedora developer I try to keep the kernel .config of my local builds > >>> synced with the Fedora kernel-configs. When grabbing the config from the > >>> kernel-core-5.11.0-0.rc6.141.fc34.x86_64.rpm pkg and comparing it to > >>> my local config I noticed this: > >>> > >>> # CONFIG_USB_RTL8152 is not set > >> > >> I upgraded to rawhide yesterday evening (I find it easiest to fix FTBFS > >> errors when actually running rawhide) so now I'm running: > >> > >> 5.11.0-0.rc6.20210204git61556703b610.144.fc34.x86_64 > >> > >> And I can confirm that I no longer have working ethernet on my dock, > >> can we get this fixed please ? (see below for root-cause analysis) > >> > > Thanks a ton for sending this. I killed the description block there so > > it should be fixed for the rc7 build tomorrow. > > Thank you for fixing this. > > When I found that the description block was the issue I assumed that > those description block(s) where somehow auto-generated. > Is that not the case? > > And if that actually is the case, then won't this problem come back the > first time the description part of the file gets re-generated ? > The description block is generated for a new config item, when there is a new config item. Existing config items are not touched. The only way this should get re-generated is if upstream removes the Kconfig option, we delete it locally, and then they add it back. Justin _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
